[UI Tests] Disable Auto Fill Passwords for UI Tests #21034
Conversation
|
| App Name |  WordPress Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr21034-628f6e9 | |
| Version | 22.7 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | 628f6e9 | |
| App Center Build | WPiOS - One-Offs #6327 |
|
| App Name |  Jetpack Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr21034-628f6e9 | |
| Version | 22.7 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | 628f6e9 | |
| App Center Build | jetpack-installable-builds #5354 |
jostnes
left a comment
jostnes
left a comment
There was a problem hiding this comment.
Thanks for making this change @tiagomar! Tested it out locally, and it works as described.
While this still depends on UI interaction (I know you're working on a V2, super looking forward to that!), this is an improvement to the current implementation where we anticipate and wait to dismiss the pop-up on multiple screens. 
mokagio
left a comment
mokagio
left a comment
There was a problem hiding this comment.
Thank you for implementing this @tiagomar !
It's a neater solution than my previous patch to conditionally dismiss the prompt. It should also remove the delay introduced by checking for the prompt every time.
- Have you considered implementing the function at the UITestsFoundation framework level? That would automatically ensure both UI tests targets have access to it, regardless of what will happen to the target membership of
UITests/Utils/XCTest+Extensions.swift - I wish there was a "before all test cases" where we could put this call, as I think it's should be required only once (unless we reset the Simulator between tests, which I don't believe we do).
NSPrincipalClassmight be a promising avenue.
|
Thanks for checking and commenting, @mokagio! Especially for the nice tip around I have this draft PR (still waiting for the tests to run in CI) that addresses both points. |
Description
The objective of this PR is to disable Auto Fill Passwords under Settings for UI Tests to avoid the burden of dealing with the
Save Passwordprompt, which is handled now in regular runs but it's heavily impacted by the long delays during Login perceived in CI (analysis available below).iPad FAIL/PASS analysis
iPhone FAIL/PASS analysis
Testing